NetMesh/components/ai/externalAgentHistory.test.ts

import assert from "node:assert/strict";
import test from "node:test";

import type { ChatMessage } from "../../infrastructure/ai/types.ts";
import { createTerminalSelectionAttachment } from "../../application/state/terminalSelectionAttachment.ts";
import {
  buildExternalAgentHistoryMessages,
  buildExternalAgentHistoryMessagesForBridge,
} from "./externalAgentHistory.ts";

function message(
  id: string,
  role: ChatMessage["role"],
  content: string,
  extra: Partial<ChatMessage> = {},
): ChatMessage {
  return {
    id,
    role,
    content,
    timestamp: 1,
    ...extra,
  };
}

test("buildExternalAgentHistoryMessages compacts older external agent context and keeps only recent raw turns", () => {
  const messages: ChatMessage[] = [
    message("u1", "user", "我希望最小改动，不要添加很多 test"),
    message("a1", "assistant", "已按最小改动处理"),
    message("u2", "user", "MCP 不允许使用，Windows 上不要假设 pwsh.exe"),
    message("a2", "assistant", "PR #738 已创建，commit 4181a2c"),
    message("u3", "user", "帮我上网查查优化方案，每轮都带历史太慢了"),
    message("a3", "assistant", "建议 SDK agent history compaction"),
    message("tool1", "tool", "", {
      toolResults: [
        {
          toolCallId: "search",
          content: `error: ${"large output ".repeat(500)}`,
          isError: true,
        },
      ],
    }),
    message("u4", "user", "好的"),
    message("a4", "assistant", "准备实现"),
    message("u5", "user", "继续"),
    message("a5", "assistant", "继续处理"),
    message("u6", "user", "现在提交"),
    message("a6", "assistant", "还没提交"),
  ];

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Compact prior Netcatty UI context/);
  assert.match(result[0].content, /最小改动/);
  assert.match(result[0].content, /pwsh\.exe/);
  assert.match(result[0].content, /PR #738/);
  assert.ok(result[0].content.length <= 3000);

  assert.ok(result.length <= 7);
  assert.deepEqual(
    result.slice(1).map((entry) => entry.content),
    ["好的", "准备实现", "继续", "继续处理", "现在提交", "还没提交"],
  );
  assert.ok(result.every((entry) => entry.content.length <= 3000));
});

test("buildExternalAgentHistoryMessagesForBridge keeps fallback history available for stale SDK agent session recovery", () => {
  const messages = [message("u1", "user", "继续处理这个历史压缩问题")];

  assert.equal(buildExternalAgentHistoryMessagesForBridge([], "sdk-session-1"), undefined);
  assert.deepEqual(
    buildExternalAgentHistoryMessagesForBridge(messages, "sdk-session-1"),
    buildExternalAgentHistoryMessages(messages),
  );
});

test("buildExternalAgentHistoryMessages replaces historical terminal selection attachments with placeholders", () => {
  const terminalSelection = createTerminalSelectionAttachment("docker ps -a\npermission denied");
  assert.ok(terminalSelection);
  const messages: ChatMessage[] = [
    message("u1", "user", "", {
      attachments: [terminalSelection],
    }),
  ];

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result.length, 1);
  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Historical terminal selection omitted from replay/);
  assert.match(result[0].content, /docker ps -a/);
  assert.doesNotMatch(result[0].content, /permission denied/);
});

test("buildExternalAgentHistoryMessages preserves older substantive user instructions outside the recent raw window", () => {
  const messages: ChatMessage[] = [
    message("u1", "user", "Keep this incremental and do not refactor unrelated files."),
    message("a1", "assistant", "Understood."),
  ];

  for (let index = 2; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `filler assistant message ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Keep this incremental and do not refactor unrelated files\./);
  assert.deepEqual(
    result.slice(-6).map((entry) => entry.content),
    [
      "filler user message 11",
      "filler assistant message 11",
      "filler user message 12",
      "filler assistant message 12",
      "filler user message 13",
      "filler assistant message 13",
    ],
  );
});

test("buildExternalAgentHistoryMessages preserves short important user constraints outside the recent raw window", () => {
  const messages: ChatMessage[] = [
    message("u1", "user", "不要提交"),
    message("a1", "assistant", "收到"),
  ];

  for (let index = 2; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `filler assistant message ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /不要提交/);
});

test("buildExternalAgentHistoryMessages does not treat pr inside ordinary words as important", () => {
  // Original intent: `\bpr\b` in IMPORTANT_PATTERNS must NOT match 'pr'
  // inside ordinary English words like 'approach' / 'improve' / 'prepare'.
  // Those words land at priority=1 (kept only as space allows) while the
  // 不要提交 line lands at priority=2 (always preferred). The check below
  // doesn't assert that the ordinary words are absent from the compact
  // section — they may legitimately survive when budget allows; that's
  // intentional after we stopped blanket-dropping short user messages.
  // What we DO verify: the priority-2 line is selected, which is only
  // possible if the IMPORTANT_PATTERNS regex correctly distinguishes it
  // from the surrounding short ordinary-word turns.
  const messages: ChatMessage[] = [
    message("u1", "user", "不要提交"),
    message("a1", "assistant", "收到"),
    message("u2", "user", "approach"),
    message("a2", "assistant", "ack"),
    message("u3", "user", "improve"),
    message("a3", "assistant", "ack"),
    message("u4", "user", "prepare"),
    message("a4", "assistant", "ack"),
  ];

  for (let index = 5; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `filler assistant message ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /不要提交/);
});

test("buildExternalAgentHistoryMessages prioritizes later durable instructions over older filler prompts", () => {
  const messages: ChatMessage[] = [];

  for (let index = 1; index <= 12; index += 1) {
    messages.push(
      message(
        `u${index}`,
        "user",
        `Please continue with implementation step ${index} and keep momentum by following the current plan carefully.`,
      ),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  messages.push(
    message("u13", "user", "Keep the existing layout and copy wording unchanged."),
    message("a13", "assistant", "Understood."),
  );

  for (let index = 14; index <= 18; index += 1) {
    messages.push(
      message(
        `u${index}`,
        "user",
        `Please continue with implementation step ${index} and keep momentum by following the current plan carefully.`,
      ),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Keep the existing layout and copy wording unchanged\./);
});

test("buildExternalAgentHistoryMessages preserves older substantive assistant context that later user prompts can reference", () => {
  const messages: ChatMessage[] = [
    message("u1", "user", "Please propose a migration plan for the sidebar state."),
    message(
      "a1",
      "assistant",
      "Plan: 1. Introduce a dedicated hook for the panel stack. 2. Move the derived view state into that hook. 3. Keep the existing UI copy and layout. 4. Add a regression test around back navigation.",
    ),
  ];

  for (let index = 2; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  messages.push(message("u14", "user", "Apply step 2 of your plan now."));

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Move the derived view state into that hook\./);
});

test("buildExternalAgentHistoryMessages preserves short non-trivial user constraints that miss the IMPORTANT regex", () => {
  // Regression: short load-bearing instructions like "Use ssh2" / "中文输出"
  // would previously be dropped by a blanket length<10 heuristic, even
  // though they don't match any TRIVIAL pattern.
  const messages: ChatMessage[] = [
    message("u1", "user", "Use ssh2"),
    message("a1", "assistant", "Got it."),
    message("u2", "user", "中文输出"),
    message("a2", "assistant", "明白"),
  ];

  // Push enough later turns so u1/u2 fall outside the recent raw window
  // and have to survive via the durable-user compaction path.
  for (let index = 3; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `filler assistant message ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Use ssh2/);
  assert.match(result[0].content, /中文输出/);
});

test("buildExternalAgentHistoryMessages still drops one-word filler user messages", () => {
  // Sanity: removing the length<10 heuristic must not cause "ok" / "继续" /
  // "thanks" filler to leak into the compact section.
  const messages: ChatMessage[] = [
    message("u1", "user", "ok"),
    message("a1", "assistant", "ack"),
    message("u2", "user", "继续"),
    message("a2", "assistant", "继续处理"),
  ];

  for (let index = 3; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `filler assistant message ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  // u1 / u2 fall outside the recent raw window. The compact context, if it
  // exists, must not surface these trivial turns as durable user requests.
  if (result.length > 0 && result[0].role === "user") {
    assert.doesNotMatch(result[0].content, /User request: ok\b/);
    assert.doesNotMatch(result[0].content, /User request: 继续/);
  }
});

test("buildExternalAgentHistoryMessages keeps bounded recent terminal evidence", () => {
  // Historical terminal output stays self-describing and useful while
  // remaining bounded on every follow-up.
  const bigToolOutput = "DATA ".repeat(300); // ~1500 chars — bigger than summary cap but smaller than raw cap
  const messages: ChatMessage[] = [
    message("u1", "user", "cat /etc/hosts"),
    message("a1", "assistant", "", {
      toolCalls: [{ id: "call1", name: "terminal", arguments: { cmd: "cat /etc/hosts" } }],
    }),
    message("tool1", "tool", "", {
      toolResults: [
        { toolCallId: "call1", content: bigToolOutput, isError: false },
      ],
    }),
    message("u2", "user", "use that output"),
  ];

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  assert.match(flat, /Tool result \[from terminal.*?cat \/etc\/hosts.*?\] \(call1\): \[Historical terminal output omitted from replay/);
  assert.match(flat, /outputChars=1500/);
  assert.match(flat, /DATA DATA DATA/);
  const toolResultIdx = flat.indexOf("Tool result [from terminal");
  assert.ok(toolResultIdx >= 0, "tool result line must appear in raw window");
  const toolResultChunk = flat.slice(toolResultIdx);
  assert.ok(
    toolResultChunk.length < 2_100,
    `expected terminal result evidence to stay bounded, got ${toolResultChunk.length}`,
  );
});

test("buildExternalAgentHistoryMessages inlines tool_call name+args so tool_result is interpretable without the preceding assistant turn", () => {
  // Regression: if the raw window starts mid-tool-interaction, the
  // preceding assistant tool_call message may be outside the 6-item
  // slice. Without the call's name/args inline on the result line, the
  // AI sees opaque bytes and "use that output" becomes ambiguous.
  const messages: ChatMessage[] = [
    // Early filler to push the tool_call off the raw window
    message("u0", "user", "prior chatter"),
    message("a0", "assistant", "prior reply"),
    message("u1", "user", "cat /etc/hosts"),
    message("a1", "assistant", "", {
      toolCalls: [
        { id: "call1", name: "terminal_exec", arguments: { command: "cat /etc/hosts" } },
      ],
    }),
    message("tool1", "tool", "", {
      toolResults: [
        { toolCallId: "call1", content: "127.0.0.1 localhost", isError: false },
      ],
    }),
    message("u2", "user", "use that output"),
    message("a2", "assistant", "acknowledged"),
    message("u3", "user", "now do the same for /etc/resolv.conf"),
  ];

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  // The tool_result line must carry the originating tool_call's name and
  // args, so even if a1 was pushed out of the raw window, the result is
  // self-describing.
  assert.match(flat, /Tool result \[from terminal_exec/);
  assert.match(flat, /cat \/etc\/hosts/);
});

test("buildExternalAgentHistoryMessages bounds the durable-candidate scan to avoid O(N) work per send on long chats", () => {
  // Regression target: codex review flagged that the compaction path
  // scanned messages.entries() over the full transcript. Build a very
  // long chat (>> MAX_DURABLE_SCAN_TURNS user turns) and verify that
  // only messages within the recent user-turn window contribute
  // durable candidates.
  const messages: ChatMessage[] = [];
  // An ancient high-priority constraint that MUST be aged out.
  messages.push(message("old-important", "user", "不要提交 old-marker-xyz"));
  messages.push(message("old-ack", "assistant", "收到"));

  // 300 filler turns between the ancient constraint and the window —
  // well past MAX_DURABLE_SCAN_TURNS (100).
  for (let i = 0; i < 300; i += 1) {
    messages.push(
      message(`u${i}`, "user", `filler user message ${i}`),
      message(`a${i}`, "assistant", `filler assistant message ${i}`),
    );
  }

  // A recent constraint that should survive.
  messages.push(message("recent-important", "user", "不要提交 recent-marker-abc"));
  for (let i = 0; i < 5; i += 1) {
    messages.push(
      message(`t${i}`, "user", `tail user message ${i}`),
      message(`ta${i}`, "assistant", `tail assistant message ${i}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  // Recent priority-2 constraint is kept.
  assert.match(flat, /recent-marker-abc/);
  // Ancient one past the scan window is dropped — proof the bound holds.
  assert.doesNotMatch(flat, /old-marker-xyz/);
});

test("buildExternalAgentHistoryMessages preserves an early constraint in a tool-heavy chat where message count balloons past the raw-count limit", () => {
  // Regression: the previous bound was MAX_DURABLE_SCAN_MESSAGES=200 on
  // the raw message array. In a tool-heavy chat, each user turn can
  // expand to 5+ messages (user + assistant w/ toolCalls + N tool
  // results + follow-up assistant), so 200 messages might be only
  // ~40 user turns. An instruction like "不要提交" from turn 5 would
  // fall out of the scan before the turn count justified aging it out.
  //
  // Now the bound is MAX_DURABLE_SCAN_TURNS=100 user turns. Build a
  // chat with only 30 user turns but many messages per turn — the
  // early constraint must still survive.
  const messages: ChatMessage[] = [];
  messages.push(message("early-important", "user", "不要提交 EARLY_CONSTRAINT_MARKER"));
  messages.push(message("early-ack", "assistant", "收到"));

  // 35 additional turns, each with 6 messages (bloats the total
  // message count to >200 without exceeding 100 user turns).
  for (let turn = 1; turn < 36; turn += 1) {
    messages.push(message(`u${turn}`, "user", `turn ${turn} request`));
    messages.push(message(`a${turn}-plan`, "assistant", "let me check", {
      toolCalls: [
        { id: `c${turn}a`, name: "terminal_exec", arguments: { cmd: "echo a" } },
        { id: `c${turn}b`, name: "terminal_exec", arguments: { cmd: "echo b" } },
        { id: `c${turn}c`, name: "terminal_exec", arguments: { cmd: "echo c" } },
      ],
    }));
    messages.push(message(`t${turn}a`, "tool", "", {
      toolResults: [{ toolCallId: `c${turn}a`, content: `result a of turn ${turn}`, isError: false }],
    }));
    messages.push(message(`t${turn}b`, "tool", "", {
      toolResults: [{ toolCallId: `c${turn}b`, content: `result b of turn ${turn}`, isError: false }],
    }));
    messages.push(message(`t${turn}c`, "tool", "", {
      toolResults: [{ toolCallId: `c${turn}c`, content: `result c of turn ${turn}`, isError: false }],
    }));
    messages.push(message(`a${turn}-done`, "assistant", `turn ${turn} done`));
  }

  // Sanity: the message count is over 200 even though user turns are 30.
  assert.ok(messages.length > 200, `setup: expected > 200 messages, got ${messages.length}`);

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  // Under the old raw-count bound, the early constraint would age out;
  // under the turn-based bound it survives.
  assert.match(flat, /EARLY_CONSTRAINT_MARKER/);
});

test("buildExternalAgentHistoryMessages preserves short non-trivial assistant decisions that miss the keyword heuristic", () => {
  // Regression: isSubstantiveAssistantMessage previously required length
  // >= 40 OR a small English keyword match OR a numbered list. Short
  // load-bearing replies like "Use ssh2" / "rebase instead" / "中文输出"
  // satisfied none of those and were silently dropped. After a stale-
  // session recovery, "do what you suggested earlier" would then replay
  // only the user's question without the assistant's actual decision.
  const messages: ChatMessage[] = [
    message("u1", "user", "which client should I use"),
    message("a1", "assistant", "Use ssh2"),
    message("u2", "user", "output language?"),
    message("a2", "assistant", "中文输出"),
    message("u3", "user", "merge or rebase?"),
    message("a3", "assistant", "rebase instead"),
  ];

  // Pad so u1..a3 fall outside the recent raw window (last 6 items) and
  // must flow through the durable-assistant compact pass.
  for (let index = 4; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  assert.match(flat, /Use ssh2/);
  assert.match(flat, /中文输出/);
  assert.match(flat, /rebase instead/);
});

test("buildExternalAgentHistoryMessages still drops trivial assistant filler like 'ack' / 'ok' / '明白'", () => {
  // Sanity: removing the length/keyword gate must not let assistant
  // filler leak into the compact durable-assistant section.
  const messages: ChatMessage[] = [
    message("u1", "user", "prompt 1"),
    message("a1", "assistant", "ack"),
    message("u2", "user", "prompt 2"),
    message("a2", "assistant", "明白"),
    message("u3", "user", "prompt 3"),
    message("a3", "assistant", "got it"),
  ];

  for (let index = 4; index <= 13; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `more filler ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  assert.doesNotMatch(flat, /Assistant context: ack\b/);
  assert.doesNotMatch(flat, /Assistant context: got it\b/);
  assert.doesNotMatch(flat, /Assistant context: 明白/);
});

test("buildExternalAgentHistoryMessages inlines tool_call context on OLDER summarized tool results", () => {
  // Regression: the raw-window fix covered the last 6 items, but once
  // a tool result fell into the compact section (summarizeToolMessage
  // path) the `[from <name>(<args>)]` provenance label was absent.
  // With multiple older tool outputs, all surfacing as identical
  // `Tool result (callN): ...`, follow-ups like "use the resolv.conf
  // output" have no way to map to the right call.
  const messages: ChatMessage[] = [
    // Two distinct tool interactions, both pushed well outside the
    // recent raw window by later turns.
    message("u1", "user", "show hosts"),
    message("a1", "assistant", "", {
      toolCalls: [{ id: "call-hosts", name: "terminal_exec", arguments: { command: "cat /etc/hosts" } }],
    }),
    message("tool1", "tool", "", {
      toolResults: [{ toolCallId: "call-hosts", content: "127.0.0.1 localhost", isError: false }],
    }),
    message("u2", "user", "show resolv.conf"),
    message("a2", "assistant", "", {
      toolCalls: [{ id: "call-resolv", name: "terminal_exec", arguments: { command: "cat /etc/resolv.conf" } }],
    }),
    message("tool2", "tool", "", {
      toolResults: [{ toolCallId: "call-resolv", content: "nameserver 8.8.8.8", isError: false }],
    }),
    // Important user text so summarizeMessage picks these up via the
    // important-text branch; tool results themselves are always
    // summarized regardless of IMPORTANT_PATTERNS.
    message("u3", "user", "fallback plan"),
  ];

  // Filler to push the early tool results out of the 6-item raw window
  // and into the compact summary section (scanned = last 20).
  for (let index = 4; index <= 10; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  // Both older tool results must now carry provenance labels so a
  // follow-up can disambiguate them.
  assert.match(flat, /Tool result \[from terminal_exec.*?cat \/etc\/hosts/);
  assert.match(flat, /Tool result \[from terminal_exec.*?cat \/etc\/resolv\.conf/);
});

test("buildExternalAgentHistoryMessages does not duplicate recent raw turns into the compact summary section", () => {
  // Regression: the scanned loop (last 20) overlaps with recentRaw (last 6).
  // Without skipping raw-window items, the same last-6 turns would be
  // summarized in the compact section AND appended verbatim in the raw
  // section — doubling the budget cost of important user turns / large
  // tool output and crowding out older durable context.
  //
  // Setup: enough filler upfront that u3 ends up OUTSIDE the raw window
  // (so it can be asserted absent from raw), then a distinctive "raw
  // only" marker that should appear only in the last-6 raw slice.
  const messages: ChatMessage[] = [];
  for (let index = 1; index <= 6; index += 1) {
    messages.push(
      message(`uf${index}`, "user", `filler user ${index}`),
      message(`af${index}`, "assistant", `filler assistant ${index}`),
    );
  }
  // These are the last 4 user/assistant messages — guaranteed to be in
  // the last-6 raw slice. The IMPORTANT markers below would ordinarily
  // also get summarized into the compact section, duplicating the cost.
  messages.push(
    message("u-rec1", "user", "commit now IMPORTANT_RAW_MARKER please"),
    message("a-rec1", "assistant", "", {
      toolCalls: [{ id: "c1", name: "git", arguments: { op: "commit" } }],
    }),
    message("tool-rec", "tool", "", {
      toolResults: [{ toolCallId: "c1", content: "committed abc123 RAW_TOOL_MARKER", isError: false }],
    }),
    message("u-rec2", "user", "now push"),
  );

  const result = buildExternalAgentHistoryMessages(messages);

  const compact = result.find((m) => m.content.includes("[Compact prior Netcatty UI context]"));
  assert.ok(compact, "expected a compact context message");

  // Both markers belong to messages inside the raw window — they must
  // not be summarized into compact (which would double-bill them).
  assert.doesNotMatch(compact.content, /IMPORTANT_RAW_MARKER/);
  assert.doesNotMatch(compact.content, /RAW_TOOL_MARKER/);

  // Raw section still carries them verbatim.
  const raw = result.filter((m) => !m.content.includes("[Compact prior Netcatty UI context]"));
  const rawFlat = raw.map((m) => m.content).join("\n");
  assert.match(rawFlat, /IMPORTANT_RAW_MARKER/);
  assert.match(rawFlat, /RAW_TOOL_MARKER/);
});

test("buildExternalAgentHistoryMessages resolves tool_call provenance correctly when tool ids are reused across turns", () => {
  // Regression: keying toolCallIndex by raw toolCall.id alone let a later
  // assistant tool_call with the same id overwrite the older one. An
  // older tool_result in the replay history would then be annotated
  // with the wrong command (e.g. a /etc/hosts result labeled as
  // /etc/resolv.conf). Now each tool_result is indexed by its own
  // messageId + toolCallId and resolved to the most recent preceding
  // call with that id.
  const messages: ChatMessage[] = [
    message("u1", "user", "show hosts"),
    message("a1", "assistant", "", {
      toolCalls: [{ id: "call1", name: "terminal_exec", arguments: { command: "cat /etc/hosts" } }],
    }),
    message("tool-hosts", "tool", "", {
      toolResults: [{ toolCallId: "call1", content: "127.0.0.1 localhost HOSTS_BYTES", isError: false }],
    }),
    // A later assistant turn reuses the id "call1" for a different call.
    message("u2", "user", "show resolv"),
    message("a2", "assistant", "", {
      toolCalls: [{ id: "call1", name: "terminal_exec", arguments: { command: "cat /etc/resolv.conf" } }],
    }),
    message("tool-resolv", "tool", "", {
      toolResults: [{ toolCallId: "call1", content: "nameserver 8.8.8.8 RESOLV_BYTES", isError: false }],
    }),
    message("u3", "user", "ok"),
  ];

  // Pad so the first interaction lands in the compact summary pass.
  for (let index = 4; index <= 10; index += 1) {
    messages.push(
      message(`u${index}`, "user", `filler user message ${index}`),
      message(`a${index}`, "assistant", `Ack ${index}`),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);
  const flat = result.map((m) => m.content).join("\n---\n");

  // Each tool_result must be annotated with ITS OWN preceding call's
  // args — not whichever assistant tool_call happened to win the
  // last-write on the shared id.
  //
  // Extract the two Tool-result lines and match each to its expected
  // args. Use non-greedy .*? — the args JSON can contain parentheses.
  const hostsMatch = flat.match(/Tool result \[from [^\]]*?cat \/etc\/hosts[^\]]*?\][^\n]*Historical terminal output omitted from replay[^\n]*cat \/etc\/hosts/);
  const resolvMatch = flat.match(/Tool result \[from [^\]]*?cat \/etc\/resolv\.conf[^\]]*?\][^\n]*Historical terminal output omitted from replay[^\n]*cat \/etc\/resolv\.conf/);
  assert.match(flat, /HOSTS_BYTES/);
  assert.match(flat, /RESOLV_BYTES/);

  assert.ok(hostsMatch, "hosts result must still be labeled with cat /etc/hosts despite later id reuse");
  assert.ok(resolvMatch, "resolv result must be labeled with cat /etc/resolv.conf");
});

test("buildExternalAgentHistoryMessages preserves assistant-only compact context", () => {
  const messages: ChatMessage[] = [
    message("u1", "user", "ok"),
    message(
      "a1",
      "assistant",
      "Plan: 1. Move parser setup into a dedicated hook. 2. Keep storage schema unchanged. 3. Add a regression test.",
    ),
  ];

  for (let index = 2; index <= 7; index += 1) {
    messages.push(
      message(`u${index}`, "user", index % 2 === 0 ? "ok" : "continue"),
      message(`a${index}`, "assistant", "ack"),
    );
  }

  const result = buildExternalAgentHistoryMessages(messages);

  assert.equal(result[0].role, "user");
  assert.match(result[0].content, /Move parser setup into a dedicated hook\./);
});