[Init] Initial commit - NetMesh terminal manager
Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
This commit is contained in:
152
components/terminal/runtime/terminalLinkHandler.test.ts
Normal file
152
components/terminal/runtime/terminalLinkHandler.test.ts
Normal file
@@ -0,0 +1,152 @@
|
||||
import test from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import { readFileSync } from "node:fs";
|
||||
|
||||
import { createTerminalLinkHandler } from "./terminalLinkHandler";
|
||||
|
||||
const click = {
|
||||
ctrlKey: false,
|
||||
altKey: false,
|
||||
metaKey: false,
|
||||
shiftKey: false,
|
||||
} as MouseEvent;
|
||||
|
||||
test("OSC 8 links use the Netcatty external browser bridge", async () => {
|
||||
const opened: string[] = [];
|
||||
const confirmed: string[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => true,
|
||||
openExternal: async (uri) => opened.push(uri),
|
||||
confirmOscLink: (uri) => {
|
||||
confirmed.push(uri);
|
||||
return true;
|
||||
},
|
||||
openWindow: () => {
|
||||
throw new Error("window.open should not be used when the bridge is available");
|
||||
},
|
||||
});
|
||||
|
||||
handler.activateOsc(click, "https://github.com/flyspray/flyspray");
|
||||
await Promise.resolve();
|
||||
|
||||
assert.deepEqual(confirmed, ["https://github.com/flyspray/flyspray"]);
|
||||
assert.deepEqual(opened, ["https://github.com/flyspray/flyspray"]);
|
||||
});
|
||||
|
||||
test("OSC 8 links do not open when the user rejects the safety confirmation", async () => {
|
||||
const opened: string[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => true,
|
||||
openExternal: async (uri) => opened.push(uri),
|
||||
confirmOscLink: () => false,
|
||||
});
|
||||
|
||||
handler.activateOsc(click, "https://example.com");
|
||||
await Promise.resolve();
|
||||
|
||||
assert.deepEqual(opened, []);
|
||||
});
|
||||
|
||||
test("terminal links still honor the configured activation modifier", async () => {
|
||||
const opened: string[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => false,
|
||||
openExternalAvailable: () => true,
|
||||
openExternal: async (uri) => opened.push(uri),
|
||||
confirmOscLink: () => true,
|
||||
});
|
||||
|
||||
handler.activate(click, "https://example.com");
|
||||
await Promise.resolve();
|
||||
|
||||
assert.deepEqual(opened, []);
|
||||
});
|
||||
|
||||
test("terminal links reject non-http protocols", async () => {
|
||||
const opened: string[] = [];
|
||||
const warnings: unknown[][] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => true,
|
||||
openExternal: async (uri) => opened.push(uri),
|
||||
confirmOscLink: () => true,
|
||||
warn: (...args) => warnings.push(args),
|
||||
});
|
||||
|
||||
handler.activate(click, "file:///etc/passwd");
|
||||
await Promise.resolve();
|
||||
|
||||
assert.deepEqual(opened, []);
|
||||
assert.equal(warnings.length, 1);
|
||||
});
|
||||
|
||||
test("terminal links fall back to window.open when the bridge is unavailable", async () => {
|
||||
const opened: string[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => false,
|
||||
confirmOscLink: () => true,
|
||||
openExternal: async () => {
|
||||
throw new Error("bridge should not be used when unavailable");
|
||||
},
|
||||
openWindow: (uri) => opened.push(uri),
|
||||
});
|
||||
|
||||
handler.activate(click, "https://example.com");
|
||||
await Promise.resolve();
|
||||
|
||||
assert.deepEqual(opened, ["https://example.com"]);
|
||||
});
|
||||
|
||||
test("terminal links do not report a noopener fallback as blocked", async () => {
|
||||
const failures: unknown[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => false,
|
||||
confirmOscLink: () => true,
|
||||
openExternal: async () => {
|
||||
throw new Error("bridge should not be used when unavailable");
|
||||
},
|
||||
openWindow: () => null,
|
||||
onError: (error) => failures.push(error),
|
||||
});
|
||||
|
||||
await handler.open("https://example.com");
|
||||
|
||||
assert.deepEqual(failures, []);
|
||||
});
|
||||
|
||||
test("terminal link failures are reported to the UI", async () => {
|
||||
const failures: unknown[] = [];
|
||||
const handler = createTerminalLinkHandler({
|
||||
canActivate: () => true,
|
||||
openExternalAvailable: () => true,
|
||||
confirmOscLink: () => true,
|
||||
openExternal: async () => {
|
||||
throw new Error("no browser available");
|
||||
},
|
||||
onError: (error) => failures.push(error),
|
||||
warn: () => {},
|
||||
});
|
||||
|
||||
handler.activate(click, "https://example.com");
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
|
||||
assert.equal(failures.length, 1);
|
||||
assert.match(String(failures[0]), /no browser available/);
|
||||
});
|
||||
|
||||
test("the xterm OSC 8 provider is wired to the confirmed terminal link path", () => {
|
||||
const runtimeSource = readFileSync(
|
||||
new URL("./createXTermRuntime.ts", import.meta.url),
|
||||
"utf8",
|
||||
);
|
||||
|
||||
assert.match(
|
||||
runtimeSource,
|
||||
/linkHandler:\s*\{\s*activate: terminalLinkHandler\.activateOsc,\s*\}/,
|
||||
);
|
||||
});
|
||||
Reference in New Issue
Block a user