[Init] Initial commit - NetMesh terminal manager
Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
This commit is contained in:
98
infrastructure/ai/harness/cattyToolApproval.test.ts
Normal file
98
infrastructure/ai/harness/cattyToolApproval.test.ts
Normal file
@@ -0,0 +1,98 @@
|
||||
import { describe, it } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { buildCattyToolApproval } from './cattyToolApproval';
|
||||
|
||||
describe('buildCattyToolApproval', () => {
|
||||
it('auto-approves read-only tools', async () => {
|
||||
const approval = buildCattyToolApproval({ permissionMode: 'confirm', chatSessionId: 'chat-1' });
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-1',
|
||||
toolName: 'terminal_read_context',
|
||||
input: { range: 'viewport' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.equal(result, undefined);
|
||||
});
|
||||
|
||||
it('allows observer-bypass write tools in observer mode', async () => {
|
||||
const approval = buildCattyToolApproval({ permissionMode: 'observer', chatSessionId: 'chat-1' });
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-stop',
|
||||
toolName: 'terminal_stop',
|
||||
input: { jobId: 'job-1' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.equal(result, undefined);
|
||||
});
|
||||
|
||||
it('denies write tools in observer mode', async () => {
|
||||
const approval = buildCattyToolApproval({ permissionMode: 'observer', chatSessionId: 'chat-1' });
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-2',
|
||||
toolName: 'sftp_write_file',
|
||||
input: { path: '/tmp/x', content: 'hi' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.deepEqual(result, {
|
||||
type: 'denied',
|
||||
reason: 'Observer mode blocks write operations.',
|
||||
});
|
||||
});
|
||||
|
||||
it('auto-approves write tools in auto mode', async () => {
|
||||
const approval = buildCattyToolApproval({ permissionMode: 'auto', chatSessionId: 'chat-1' });
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-3',
|
||||
toolName: 'sftp_write_file',
|
||||
input: { path: '/tmp/x', content: 'hi' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.equal(result, undefined);
|
||||
});
|
||||
|
||||
it('awaits user approval in confirm mode for write tools', async () => {
|
||||
let approvalRequested = false;
|
||||
const approval = buildCattyToolApproval({
|
||||
permissionMode: 'confirm',
|
||||
chatSessionId: 'chat-1',
|
||||
requestApproval: async (toolCallId, toolName) => {
|
||||
approvalRequested = true;
|
||||
assert.equal(toolCallId, 'call-4');
|
||||
assert.equal(toolName, 'sftp_write_file');
|
||||
return true;
|
||||
},
|
||||
});
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-4',
|
||||
toolName: 'sftp_write_file',
|
||||
input: { path: '/tmp/x', content: 'hi' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.equal(approvalRequested, true);
|
||||
assert.deepEqual(result, { type: 'approved' });
|
||||
});
|
||||
|
||||
it('returns denied when confirm-mode approval is rejected', async () => {
|
||||
const approval = buildCattyToolApproval({
|
||||
permissionMode: 'confirm',
|
||||
chatSessionId: 'chat-1',
|
||||
requestApproval: async () => false,
|
||||
});
|
||||
const result = await approval({
|
||||
toolCall: {
|
||||
toolCallId: 'call-5',
|
||||
toolName: 'sftp_write_file',
|
||||
input: { path: '/tmp/x', content: 'hi' },
|
||||
},
|
||||
} as Parameters<typeof approval>[0]);
|
||||
assert.deepEqual(result, {
|
||||
type: 'denied',
|
||||
reason: 'User denied tool execution.',
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user