NetMesh/domain/hostConnectScripts.test.ts

import assert from 'node:assert/strict';
import test from 'node:test';
import type { Host, Snippet } from './models';
import {
  appendHostConnectScript,
  ensureHostConnectScriptIds,
  getEditableHostConnectScriptIds,
  getGlobalConnectScripts,
  getHostConnectScriptIds,
  hasHostConnectAutomation,
  migrateHostConnectScriptIds,
  reorderHostConnectScript,
  removeHostConnectScript,
  resolveConnectScriptsForHost,
  shouldMarkConnectAutomationConsumed,
  shouldUseFreshSshConnectionForAutomation,
  syncHostsForSnippetTargetChange,
  syncSnippetsForHostConnectQueueSave,
} from './hostConnectScripts.ts';

const host: Host = {
  id: 'host-a',
  label: 'A',
  hostname: 'a.example',
  username: 'root',
  os: 'linux',
  protocol: 'ssh',
  tags: [],
};

const script = (overrides: Partial<Snippet>): Snippet => ({
  id: 's-default',
  label: 'default',
  command: 'nct.log("x");',
  kind: 'script',
  trigger: 'onConnect',
  ...overrides,
});

test('migrateHostConnectScriptIds prefers loginScriptId then linked onConnect scripts', () => {
  const snippets = [
    script({ id: 'login', targets: ['host-a'], order: 1000 }),
    script({ id: 'linked', targets: ['host-a'], order: 2000 }),
    script({ id: 'other', targets: ['host-a'], order: 3000 }),
  ];
  const migrated = migrateHostConnectScriptIds({ ...host, loginScriptId: 'login' }, snippets);
  assert.deepEqual(migrated, ['login', 'linked', 'other']);
});

test('resolveConnectScriptsForHost runs globals before host queue and dedupes', () => {
  const snippets = [
    script({ id: 'global', targetsAllHosts: true, order: 1000, label: 'Global' }),
    script({ id: 'host-only', targets: ['host-a'], order: 2000, label: 'Host' }),
    script({ id: 'both', targetsAllHosts: true, targets: ['host-a'], order: 3000, label: 'Both' }),
  ];
  const resolved = resolveConnectScriptsForHost(
    { ...host, connectScriptIds: ['both', 'host-only'] },
    snippets,
  );
  assert.deepEqual(resolved.map((item) => item.id), ['global', 'both', 'host-only']);
});

test('resolveConnectScriptsForHost dynamically inserts matching group scripts', () => {
  const snippets = [
    script({ id: 'global', targetsAllHosts: true, order: 1000 }),
    script({ id: 'group', targetGroups: ['Production'], order: 2000 }),
    script({ id: 'host-only', targets: ['host-a'], order: 3000 }),
  ];
  const groupedHost = { ...host, group: 'Production/Web', connectScriptIds: ['host-only'] };
  assert.deepEqual(
    resolveConnectScriptsForHost(groupedHost, snippets).map((item) => item.id),
    ['global', 'group', 'host-only'],
  );
  assert.deepEqual(
    resolveConnectScriptsForHost({ ...groupedHost, group: 'Staging' }, snippets).map((item) => item.id),
    ['global', 'host-only'],
  );
});

test('group scripts stay dynamic instead of being materialized into a new host queue', () => {
  const snippets = [script({ id: 'group', targetGroups: ['Production'] })];
  const groupedHost = { ...host, group: 'Production' };
  assert.deepEqual(migrateHostConnectScriptIds(groupedHost, snippets), []);
  assert.deepEqual(resolveConnectScriptsForHost(groupedHost, snippets).map((item) => item.id), ['group']);
});

test('hasHostConnectAutomation covers host, global, and unresolved connect scripts', () => {
  assert.equal(
    hasHostConnectAutomation(
      { ...host, connectScriptIds: ['host-script'] },
      [script({ id: 'host-script', targets: ['host-a'] })],
    ),
    true,
  );
  assert.equal(
    hasHostConnectAutomation(host, [script({ id: 'global', targetsAllHosts: true })]),
    true,
  );
  assert.equal(
    hasHostConnectAutomation({ ...host, loginScriptId: 'not-loaded-yet' }, []),
    true,
  );
  assert.equal(hasHostConnectAutomation(host, []), false);
});

test('fresh SSH automation policy is conservative before vault hydration and for pending scripts', () => {
  assert.equal(shouldUseFreshSshConnectionForAutomation({
    host,
    snippets: [],
    vaultInitialized: false,
  }), true);
  assert.equal(shouldUseFreshSshConnectionForAutomation({
    host,
    snippets: [],
    vaultInitialized: true,
    hasPendingScript: true,
  }), true);
  assert.equal(shouldUseFreshSshConnectionForAutomation({
    host,
    snippets: [],
    vaultInitialized: true,
  }), false);
  assert.equal(shouldUseFreshSshConnectionForAutomation({
    host,
    snippets: [script({ id: 'global', targetsAllHosts: true })],
    vaultInitialized: true,
    connectAutomationConsumed: true,
  }), false);
  assert.equal(shouldUseFreshSshConnectionForAutomation({
    host,
    snippets: [script({ id: 'global', targetsAllHosts: true })],
    vaultInitialized: true,
    hasPendingScript: true,
    connectAutomationConsumed: true,
  }), true);
});

test('empty hydrated vault finalizes the current connection automation decision', () => {
  assert.equal(shouldMarkConnectAutomationConsumed({
    allConnectScriptsDone: true,
    vaultInitialized: true,
    hasUnresolvedBindings: false,
  }), true);
  assert.equal(shouldMarkConnectAutomationConsumed({
    allConnectScriptsDone: true,
    vaultInitialized: false,
    hasUnresolvedBindings: false,
  }), false);
});

test('append updates host connectScriptIds order', () => {
  const snippets = [
    script({ id: 'a', targets: ['host-a'] }),
    script({ id: 'b', targets: ['host-a'] }),
  ];
  let next = appendHostConnectScript(host, 'a', snippets);
  next = appendHostConnectScript(next, 'b', snippets);
  assert.deepEqual(getHostConnectScriptIds(next, snippets), ['a', 'b']);
});

test('append keeps default manual scripts in the editable host queue', () => {
  const snippets = [
    script({ id: 'reset', label: 'reset-password', trigger: 'manual' }),
    script({ id: 'teest', label: 'teest', trigger: 'manual' }),
  ];

  let next = appendHostConnectScript(host, 'reset', snippets);
  assert.deepEqual(getEditableHostConnectScriptIds(next, snippets), ['reset']);
  // Runtime still ignores non-onConnect until host save promotes the trigger.
  assert.deepEqual(getHostConnectScriptIds(next, snippets), []);

  next = appendHostConnectScript(next, 'teest', snippets);
  assert.deepEqual(getEditableHostConnectScriptIds(next, snippets), ['reset', 'teest']);
  assert.deepEqual(next.connectScriptIds, ['reset', 'teest']);
});

test('ensureHostConnectScriptIds preserves pending manual queue entries while editing', () => {
  const snippets = [script({ id: 'reset', trigger: 'manual' })];
  const draft = { ...host, connectScriptIds: ['reset', 'missing'] };
  const ensured = ensureHostConnectScriptIds(draft, snippets);
  assert.deepEqual(ensured.connectScriptIds, ['reset']);
  assert.deepEqual(getEditableHostConnectScriptIds(ensured, snippets), ['reset']);
  assert.deepEqual(getHostConnectScriptIds(ensured, snippets), []);
});

test('syncSnippetsForHostConnectQueueSave promotes already-persisted manual queue entries', () => {
  const snippets = [
    script({ id: 'reset', trigger: 'manual', targets: [] }),
    script({ id: 'ready', trigger: 'onConnect', targets: ['host-a'] }),
  ];
  const { snippets: next, changed, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    snippets,
    'host-a',
    ['reset', 'ready'],
    ['reset', 'ready'],
  );
  assert.equal(changed, true);
  assert.equal(next.find((item) => item.id === 'reset')?.trigger, 'onConnect');
  assert.deepEqual(next.find((item) => item.id === 'reset')?.targets, ['host-a']);
  assert.equal(next.find((item) => item.id === 'ready'), snippets[1]);
  assert.deepEqual(connectScriptIds, ['reset', 'ready']);
});

test('syncSnippetsForHostConnectQueueSave leaves global onConnect scripts untouched', () => {
  const global = script({ id: 'both', targetsAllHosts: true, targets: ['host-a'] });
  const { snippets: next, changed, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    [global],
    'host-a',
    ['both'],
    ['both'],
  );
  assert.equal(changed, false);
  assert.equal(next[0], global);
  assert.equal(next[0].targetsAllHosts, true);
  assert.deepEqual(connectScriptIds, ['both']);
});

test('syncSnippetsForHostConnectQueueSave promotes global manual without clearing targetsAllHosts', () => {
  const globalManual = script({
    id: 'everywhere',
    trigger: 'manual',
    targetsAllHosts: true,
  });
  const { snippets: next, changed, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    [globalManual],
    'host-a',
    ['everywhere'],
    ['everywhere'],
  );
  assert.equal(changed, true);
  assert.equal(next[0].trigger, 'onConnect');
  assert.equal(next[0].targetsAllHosts, true);
  assert.deepEqual(connectScriptIds, ['everywhere']);
});

test('syncSnippetsForHostConnectQueueSave does not re-promote concurrently demoted scripts', () => {
  const baseline = [script({ id: 'run', trigger: 'onConnect', targets: ['host-a'] })];
  const demoted = [script({ id: 'run', trigger: 'manual', targets: ['host-a'] })];
  const { snippets: next, changed, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    demoted,
    'host-a',
    ['run'],
    ['run'],
    { baselineSnippets: baseline },
  );
  assert.equal(changed, true);
  assert.equal(next[0].trigger, 'manual');
  assert.deepEqual(connectScriptIds, []);
});

test('syncSnippetsForHostConnectQueueSave preserves concurrent non-onConnect trigger edits', () => {
  const baseline = [script({ id: 'run', trigger: 'manual', targets: ['host-a'] })];
  const retargeted = [script({ id: 'run', trigger: 'onOutput', triggerPattern: 'ERR', targets: ['host-a'] })];
  const { snippets: next, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    retargeted,
    'host-a',
    ['run'],
    ['run'],
    { baselineSnippets: baseline },
  );
  assert.equal(next[0].trigger, 'onOutput');
  assert.equal(next[0].triggerPattern, 'ERR');
  assert.deepEqual(connectScriptIds, []);
});

test('syncSnippetsForHostConnectQueueSave preserves concurrent target removals', () => {
  const baseline = [script({ id: 'run', trigger: 'onConnect', targets: ['host-a', 'host-b'] })];
  const unlinked = [script({ id: 'run', trigger: 'onConnect', targets: ['host-b'] })];
  const { snippets: next, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    unlinked,
    'host-a',
    ['run'],
    ['run'],
    { baselineSnippets: baseline },
  );
  assert.deepEqual(next[0].targets, ['host-b']);
  assert.deepEqual(connectScriptIds, []);
});

test('syncSnippetsForHostConnectQueueSave preserves concurrent target removals for manual scripts', () => {
  const baseline = [script({ id: 'run', trigger: 'manual', targets: ['host-a', 'host-b'] })];
  const unlinked = [script({ id: 'run', trigger: 'manual', targets: ['host-b'] })];
  const { snippets: next, connectScriptIds } = syncSnippetsForHostConnectQueueSave(
    unlinked,
    'host-a',
    ['run'],
    ['run'],
    { baselineSnippets: baseline },
  );
  assert.equal(next[0].trigger, 'manual');
  assert.deepEqual(next[0].targets, ['host-b']);
  assert.deepEqual(connectScriptIds, []);
});

test('syncSnippetsForHostConnectQueueSave syncs other targeted hosts after promote', () => {
  const hostB: Host = {
    id: 'host-b',
    label: 'B',
    hostname: 'b.example',
    username: 'root',
    os: 'linux',
    protocol: 'ssh',
    tags: [],
    connectScriptIds: [],
  };
  const snippets = [
    script({ id: 'shared', trigger: 'manual', targets: ['host-b'] }),
  ];
  const { snippets: next, hosts, changed } = syncSnippetsForHostConnectQueueSave(
    snippets,
    'host-a',
    [],
    ['shared'],
    { hosts: [host, hostB] },
  );
  assert.equal(changed, true);
  assert.equal(next[0].trigger, 'onConnect');
  assert.deepEqual(next[0].targets, ['host-b', 'host-a']);
  assert.deepEqual(hosts?.find((item) => item.id === 'host-b')?.connectScriptIds, ['shared']);
});

test('syncHostsForSnippetTargetChange appends and removes queue entries', () => {
  const snippets = [script({ id: 'run', targets: ['host-a'], trigger: 'onConnect' })];
  const hosts = syncHostsForSnippetTargetChange(
    [host],
    script({ id: 'run', targets: ['host-a'], trigger: 'onConnect' }),
    [],
    snippets,
  );
  assert.deepEqual(hosts[0].connectScriptIds, ['run']);

  const removed = syncHostsForSnippetTargetChange(
    hosts,
    script({ id: 'run', targets: [], trigger: 'onConnect' }),
    ['host-a'],
    snippets,
  );
  assert.deepEqual(removed[0].connectScriptIds, []);
});

test('getGlobalConnectScripts sorts by order', () => {
  const snippets = [
    script({ id: 'z', targetsAllHosts: true, order: 2000, label: 'Z' }),
    script({ id: 'a', targetsAllHosts: true, order: 1000, label: 'A' }),
  ];
  assert.deepEqual(getGlobalConnectScripts(snippets).map((item) => item.id), ['a', 'z']);
});

test('reorderHostConnectScript moves item before or after target', () => {
  const snippets = [
    script({ id: 'a', targets: ['host-a'] }),
    script({ id: 'b', targets: ['host-a'] }),
    script({ id: 'c', targets: ['host-a'] }),
  ];
  const base = { ...host, connectScriptIds: ['a', 'b', 'c'] };
  const movedAfter = reorderHostConnectScript(base, 'a', 'c', 'after', snippets);
  assert.deepEqual(getHostConnectScriptIds(movedAfter, snippets), ['b', 'c', 'a']);
  const movedBefore = reorderHostConnectScript(base, 'c', 'a', 'before', snippets);
  assert.deepEqual(getHostConnectScriptIds(movedBefore, snippets), ['c', 'a', 'b']);
});

test('removeHostConnectScript clears empty queue', () => {
  const snippets = [script({ id: 'only', targets: ['host-a'] })];
  const updated = removeHostConnectScript(
    { ...host, connectScriptIds: ['only'] },
    'only',
    snippets,
  );
  assert.deepEqual(updated.connectScriptIds, []);
});