Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
133 lines
3.4 KiB
TypeScript
133 lines
3.4 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
import {
|
|
scrollTerminalToBottomAfterInputIfEnabled,
|
|
scrollTerminalToBottomIfNeeded,
|
|
shouldScrollOnTerminalInput,
|
|
} from "./terminalScroll.ts";
|
|
|
|
const createScrollTarget = (viewportY: number, baseY = 10_000) => {
|
|
let scrollCalls = 0;
|
|
return {
|
|
terminal: {
|
|
buffer: {
|
|
active: {
|
|
baseY,
|
|
viewportY,
|
|
},
|
|
},
|
|
scrollToBottom() {
|
|
scrollCalls += 1;
|
|
},
|
|
},
|
|
get scrollCalls() {
|
|
return scrollCalls;
|
|
},
|
|
};
|
|
};
|
|
|
|
test("does not request another scroll when the terminal is already at the bottom", () => {
|
|
const fixture = createScrollTarget(10_000);
|
|
|
|
const didScroll = scrollTerminalToBottomIfNeeded(fixture.terminal);
|
|
|
|
assert.equal(didScroll, false);
|
|
assert.equal(fixture.scrollCalls, 0);
|
|
});
|
|
|
|
test("scrolls to the bottom when the user is viewing earlier output", () => {
|
|
const fixture = createScrollTarget(9_900);
|
|
|
|
const didScroll = scrollTerminalToBottomIfNeeded(fixture.terminal);
|
|
|
|
assert.equal(didScroll, true);
|
|
assert.equal(fixture.scrollCalls, 1);
|
|
});
|
|
|
|
test("printable input does not request another scroll when already at the bottom", () => {
|
|
const fixture = createScrollTarget(10_000);
|
|
|
|
const didScroll = scrollTerminalToBottomAfterInputIfEnabled(
|
|
fixture.terminal,
|
|
{ scrollOnInput: true },
|
|
"f",
|
|
);
|
|
|
|
assert.equal(didScroll, false);
|
|
assert.equal(fixture.scrollCalls, 0);
|
|
});
|
|
|
|
test("printable input still scrolls when the user is viewing earlier output", () => {
|
|
const fixture = createScrollTarget(9_900);
|
|
|
|
const didScroll = scrollTerminalToBottomAfterInputIfEnabled(
|
|
fixture.terminal,
|
|
{ scrollOnInput: true },
|
|
"f",
|
|
);
|
|
|
|
assert.equal(didScroll, true);
|
|
assert.equal(fixture.scrollCalls, 1);
|
|
});
|
|
|
|
test("Ctrl+C scrolls under scrollOnInput when viewing earlier output (#2287)", () => {
|
|
const fixture = createScrollTarget(9_900);
|
|
|
|
assert.equal(
|
|
shouldScrollOnTerminalInput({ scrollOnInput: true, scrollOnKeyPress: false }, "\x03"),
|
|
true,
|
|
);
|
|
|
|
const didScroll = scrollTerminalToBottomAfterInputIfEnabled(
|
|
fixture.terminal,
|
|
{ scrollOnInput: true, scrollOnKeyPress: false },
|
|
"\x03",
|
|
);
|
|
|
|
assert.equal(didScroll, true);
|
|
assert.equal(fixture.scrollCalls, 1);
|
|
});
|
|
|
|
test("Ctrl+C still scrolls when only scrollOnKeyPress is enabled", () => {
|
|
const fixture = createScrollTarget(9_900);
|
|
|
|
const didScroll = scrollTerminalToBottomAfterInputIfEnabled(
|
|
fixture.terminal,
|
|
{ scrollOnInput: false, scrollOnKeyPress: true },
|
|
"\x03",
|
|
);
|
|
|
|
assert.equal(didScroll, true);
|
|
assert.equal(fixture.scrollCalls, 1);
|
|
});
|
|
|
|
test("Ctrl+C does not scroll when both input scroll settings are off", () => {
|
|
const fixture = createScrollTarget(9_900);
|
|
|
|
assert.equal(
|
|
shouldScrollOnTerminalInput({ scrollOnInput: false, scrollOnKeyPress: false }, "\x03"),
|
|
false,
|
|
);
|
|
|
|
const didScroll = scrollTerminalToBottomAfterInputIfEnabled(
|
|
fixture.terminal,
|
|
{ scrollOnInput: false, scrollOnKeyPress: false },
|
|
"\x03",
|
|
);
|
|
|
|
assert.equal(didScroll, false);
|
|
assert.equal(fixture.scrollCalls, 0);
|
|
});
|
|
|
|
test("non-printable keys still require scrollOnKeyPress", () => {
|
|
assert.equal(
|
|
shouldScrollOnTerminalInput({ scrollOnInput: true, scrollOnKeyPress: false }, "\r"),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
shouldScrollOnTerminalInput({ scrollOnInput: true, scrollOnKeyPress: true }, "\r"),
|
|
true,
|
|
);
|
|
});
|