Some checks failed
build-packages / resolve bundled mosh-client (push) Has been cancelled
build-packages / resolve bundled et-client (push) Has been cancelled
build-packages / build-macos (push) Has been cancelled
build-packages / build-windows (push) Has been cancelled
build-packages / build-linux-x64 (push) Has been cancelled
build-packages / build-linux-arm64 (push) Has been cancelled
build-packages / release (push) Has been cancelled
build-packages / update Nix release metadata (push) Has been cancelled
build-packages / bump homebrew tap (push) Has been cancelled
test / lint-and-test (push) Has been cancelled
AI automation / Route event (push) Has been cancelled
AI automation / Hand reopened issue to maintainers (push) Has been cancelled
AI automation / Clean source issue state (push) Has been cancelled
AI automation / Reconcile handoffs (push) Has been cancelled
AI automation / Classify issue (push) Has been cancelled
AI automation / Claude Code smoke (push) Has been cancelled
AI automation / Review issue follow-up (push) Has been cancelled
AI automation / Publish issue follow-up (push) Has been cancelled
AI automation / Implement with Claude Code (push) Has been cancelled
AI automation / Publish implement PR (push) Has been cancelled
AI automation / Continue queued issue comments (push) Has been cancelled
AI automation / Codex review loop (push) Has been cancelled
AI automation / Publish Codex fix (push) Has been cancelled
AI automation / Clear Codex dispatch marker (push) Has been cancelled
AI automation / Own PR re-request Codex (push) Has been cancelled
AI automation / External PR re-request Codex (push) Has been cancelled
AI automation / Poll Codex reaction / retry (push) Has been cancelled
build-et-binaries / build-linux-x64 (push) Has been cancelled
build-et-binaries / build-linux-arm64 (push) Has been cancelled
build-et-binaries / build-macos-universal (push) Has been cancelled
build-et-binaries / build-windows-x64 (push) Has been cancelled
build-et-binaries / release (push) Has been cancelled
112 lines
3.3 KiB
JavaScript
112 lines
3.3 KiB
JavaScript
/**
|
|
* Repro: multi-line compose bar input only sent the first line.
|
|
*
|
|
* Path: compose bar textarea -> executeSnippetCommand(text, false) ->
|
|
* multi-line autoRun -> lineDelayMs=250 -> backend writeToSession sends the
|
|
* first line immediately and queues the remaining lines in
|
|
* session.pendingAutomatedWriteTimers.
|
|
*
|
|
* Root cause: terminal-originated automatic replies used the same netcatty:write
|
|
* path without the automated flag. Treating those replies as user input cleared
|
|
* queued lines, so only the first line was sent.
|
|
*/
|
|
const test = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
|
|
const terminalBridge = require("./terminalBridge.cjs");
|
|
|
|
function initBridge(sessions) {
|
|
terminalBridge.init({
|
|
sessions,
|
|
electronModule: {
|
|
webContents: { fromId: () => ({ send() {} }) },
|
|
},
|
|
});
|
|
}
|
|
|
|
function delay(ms) {
|
|
return new Promise((resolve) => setTimeout(resolve, ms));
|
|
}
|
|
|
|
// Expected behavior: harmless terminal auto-replies must not cancel queued lines.
|
|
test("[REPRO] terminal auto-reply between automated lines must NOT cancel pending lines", async () => {
|
|
const calls = [];
|
|
const sessions = new Map();
|
|
sessions.set("ssh-1", {
|
|
stream: { signal() {}, write(data) { calls.push(data); } },
|
|
});
|
|
initBridge(sessions);
|
|
|
|
terminalBridge.writeToSession(
|
|
{ sender: {} },
|
|
{
|
|
sessionId: "ssh-1",
|
|
data: "echo one\necho two\necho three\r",
|
|
automated: true,
|
|
lineDelayMs: 20,
|
|
},
|
|
);
|
|
assert.deepEqual(calls, ["echo one\r"], "the first line is sent immediately");
|
|
|
|
terminalBridge.writeToSession({ sender: {} }, { sessionId: "ssh-1", data: "\x1b[2;1R" });
|
|
|
|
await delay(80);
|
|
|
|
assert.deepEqual(
|
|
calls,
|
|
["echo one\r", "\x1b[2;1R", "echo two\r", "echo three\r"],
|
|
"terminal auto-replies should not clear queued line writes",
|
|
);
|
|
});
|
|
|
|
test("[REPRO] Kitty keyboard query reply must NOT cancel pending lines", async () => {
|
|
const calls = [];
|
|
const sessions = new Map();
|
|
sessions.set("ssh-1", {
|
|
stream: { signal() {}, write(data) { calls.push(data); } },
|
|
});
|
|
initBridge(sessions);
|
|
|
|
terminalBridge.writeToSession(
|
|
{ sender: {} },
|
|
{
|
|
sessionId: "ssh-1",
|
|
data: "echo one\necho two\necho three\r",
|
|
automated: true,
|
|
lineDelayMs: 20,
|
|
},
|
|
);
|
|
assert.deepEqual(calls, ["echo one\r"], "the first line is sent immediately");
|
|
|
|
terminalBridge.writeToSession({ sender: {} }, { sessionId: "ssh-1", data: "\x1b[?0u" });
|
|
|
|
await delay(80);
|
|
|
|
assert.deepEqual(
|
|
calls,
|
|
["echo one\r", "\x1b[?0u", "echo two\r", "echo three\r"],
|
|
"Kitty query replies should not clear queued line writes",
|
|
);
|
|
});
|
|
|
|
// Guardrail: real user interruption must still cancel queued automated writes.
|
|
test("[GUARD] Ctrl+C between automated lines SHOULD cancel pending lines", async () => {
|
|
const calls = [];
|
|
const sessions = new Map();
|
|
sessions.set("ssh-1", {
|
|
stream: { signal() {}, write(data) { calls.push(data); } },
|
|
});
|
|
initBridge(sessions);
|
|
|
|
terminalBridge.writeToSession(
|
|
{ sender: {} },
|
|
{ sessionId: "ssh-1", data: "echo one\necho two\r", automated: true, lineDelayMs: 20 },
|
|
);
|
|
assert.deepEqual(calls, ["echo one\r"]);
|
|
|
|
terminalBridge.writeToSession({ sender: {} }, { sessionId: "ssh-1", data: "\x03" }); // Ctrl+C
|
|
await delay(60);
|
|
|
|
assert.deepEqual(calls, ["echo one\r", "\x03"], "Ctrl+C should cancel queued line writes");
|
|
});
|